fix(picker): format fzf preview entries to list width#402
Merged
Conversation
Contributor
Author
|
This is a fix for a bug introduced in #399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
PR #399 fixed the fzf-lua session picker preview gutter, but the width handling for preview mode still used the full picker width for session rows. In practice, that pushed the datetime column off the visible list pane and truncated session rows down to the title and ellipsis.
Solution
Make preview-aware width handling happen where picker item width is actually determined. The list width is now computed before the picker callback is wrapped, so fzf preview entries use the visible list pane width while the picker window itself still uses the full width.
Changes
base_picker.pick(), where itemwidth is passed into the picker callback.
opts.widthmutation fromfzf_ui(), which happenedtoo late to affect the rendered session rows.
width while fzf still receives the full window width.