Refactor: add color type helper#625
Open
thadeucity wants to merge 7 commits intostyled-components:mainfrom
Open
Refactor: add color type helper#625thadeucity wants to merge 7 commits intostyled-components:mainfrom
thadeucity wants to merge 7 commits intostyled-components:mainfrom
Conversation
Add a color type helper to identify obj type and reduce code repetition
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 90 +1
Lines 860 847 -13
Branches 323 301 -22
=========================================
- Hits 860 847 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…y/polished into refactor/add-color-type-helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A color object type is being checked the same way in 3 parts of the code.
hslToColorString.js,rgbToColorString.jsandtoColorString.js. To simplify its use and also reduce the lib size, a helper function was created to identify the color object type.The refactoring reduced the lib size by approximately 0.7% (Gziped) It is a marginal gain, but I believe any size improvement is a welcome one.