Skip to content

Stabilize Image Library E2E Tests#380

Merged
stuart-c merged 3 commits into
mainfrom
e2e-images-tests
Apr 28, 2026
Merged

Stabilize Image Library E2E Tests#380
stuart-c merged 3 commits into
mainfrom
e2e-images-tests

Conversation

@stuart-c-ai

Copy link
Copy Markdown
Collaborator

This PR completes the stabilization of the Image Library E2E tests by addressing several key issues:

  1. Selector Conflict Resolution: Renamed header buttons to use btn-header-* and dialog buttons to btn-image-* to avoid strict mode violations and shadow DOM ambiguity.
  2. Duplicate ID Fix: Resolved a duplicate id="btn-save" issue in ImageDialog.ts.
  3. Synchronization Improvements: Updated the E2E suite to use network-level synchronization (waitForResponse) and added random unique image generation to bypass backend duplicate hash detection (409 Conflict).
  4. UX Feedback: Added a success message toast for image saving to provide a reliable UI state for test verification.

These changes ensure a robust and reliable test suite for the Image Library functionality.

stuart-c
stuart-c previously approved these changes Apr 23, 2026
@stuart-c stuart-c merged commit e165c35 into main Apr 28, 2026
19 of 21 checks passed
@stuart-c stuart-c deleted the e2e-images-tests branch April 28, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants