Skip to content

Remove erlware_commons#18

Open
maehjam wants to merge 8 commits into
kickstarter/basefrom
maehjam/erlware_commons
Open

Remove erlware_commons#18
maehjam wants to merge 8 commits into
kickstarter/basefrom
maehjam/erlware_commons

Conversation

@maehjam

@maehjam maehjam commented Jul 1, 2026

Copy link
Copy Markdown

This is a rebase of #16 together with:

  • removal of some leftovers of erlware_commons:
    • Two calls in rebar3.erl
    • dependency in apps/rebar/rebar.config
  • rename the function find to search to keep the original spec of find, which is used in plugins. Make rebar_app_utils:find/2,3 deprecated.

@maehjam maehjam requested a review from bchassoul July 1, 2026 14:40
@maehjam maehjam marked this pull request as draft July 1, 2026 14:46
@maehjam maehjam force-pushed the maehjam/erlware_commons branch from 817ffaf to 2cabc79 Compare July 1, 2026 14:52
@maehjam maehjam marked this pull request as ready for review July 1, 2026 14:53
GwendalLaurent and others added 8 commits July 1, 2026 19:43
* internalize functions of ec_sermver.erl

* move ec_semver_parser inside rebar

* remove leftover call to erlware_commons

* add SPDX tags in erlware files
* remove ec_file:{is_file, is_dir}/1

* remove ec_file:{mkdir_path,mkdir_p}

* remove ec_file:remove/{2,3}

* add missing files for is_dir refactor

* remove ec_file:{write, write_term}/2

* move ec_file:real_dir_path to rebar_file_utils

* move ec_file:insecure_mkdtemp/0 to rebar_file_utils

* remove ec_file:copy/{2,3}

* remove ec_file:is_symlink/1

* add SPDX headers
* remove ec_lists:search/2 from rebar_packages

* add test case for check_all_repo correctness

* handle_missing_no_exception refactor

* remove ec_lists:search/2

* replace ec_lists:find/2 by lists:search/2 + refactoring of callers

* add SPDX headers
* refactoring the logs to remove ec_cmd_logs
* remove ec_cnv

* restore r3_safe_erl_term

* add SPDX headers
This might be used in plugins
@maehjam maehjam force-pushed the maehjam/erlware_commons branch from a943f7f to 097e1c9 Compare July 1, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants