32 create a build process for the GitHub scripts#33
Merged
Conversation
Metric renamed from "Additions/Deletions Ratio" to "Net Additions Ratio" following the formula change from additions/max(deletions,1) to the bounded (additions-deletions)/(additions+deletions) formula. Updated: - Key Metrics table: new name and <0.50 target (was <3.0) - Healthy/Warning/Critical thresholds: 0.33 / 0.33-0.50 / >0.50 - Note: AI_RISK_ADDITIONS_RATIO: 3 is unchanged — that is the Claude pre-filter multiplier, not the net additions ratio threshold Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…uide Previous instructions said "Copy .github/workflows/*.yml from this repo" with no actual command. Added: - curl commands to fetch workflow files directly from GitHub - gh label create commands for 'metrics' and 'automated' labels required by the weekly issue-creation step (silent failure without these) - Explicit Settings path for disabling auto-delete of head branches - Explicit Settings path for read/write workflow permissions - gh workflow run + gh run watch for first-run verification - Note that pr-metrics.yml triggers automatically on PRs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…modules
Replaces all inline JavaScript helper functions in both GitHub Actions
workflows with direct require() calls to lib/config.js, lib/statistics.js,
and lib/metrics.js. actions/github-script@v7 runs Node.js with require()
resolving from $GITHUB_WORKSPACE after checkout — no build step needed.
Changes:
- lib/metrics.js: add isTestFile() (moved from lib/git.js) so workflows
can require('./lib/metrics') without pulling in child_process dependencies
- lib/git.js: import isTestFile from lib/metrics.js, remove local definition
- code-metrics.yml: remove 5 inline helper functions, add 3 require() calls,
replace hardcoded thresholds with CONFIG.*, replace test file regex with
isTestFile(), add missing velocity_commits_per_day to summary output,
fix classifyDoraArchetype() to use object signature matching lib/metrics.js
- pr-metrics.yml: remove 2 inline helper functions, add 2 require() calls,
replace 4x test file regex with isTestFile(), replace hardcoded thresholds
with CONFIG.*, fix classifyDoraArchetype() object signature
- CLAUDE.md: update architecture section (shared lib/ documented), remove
"update both places" warning, note single source of truth for thresholds
Adjusting lib/config.js now propagates automatically to all three components.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Workflows require('./lib/config'), require('./lib/statistics'), and
require('./lib/metrics') at runtime after checkout. Without these three
files, the workflows fail with module-not-found errors. Quick Start now
fetches all five files and notes why lib/ must be committed.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codifies the lesson from the refactor cycle: a green run does not prove new code ran. Agents must download the artifact and verify expected fields are present, and confirm the run commit SHA matches branch HEAD. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR AnalysisSize: large (based on production code) Concerns
Strengths
Commit AnalysisTotal Commits: 5
Commit Details7dbce67 Ken Judy (4/7/2026) 200fc84 Ken Judy (4/7/2026) bc777bb Ken Judy (4/7/2026) 8c9ed9a Ken Judy (4/7/2026) 350a872 Ken Judy (4/7/2026) Test CoverageTest Adequacy: needs-improvement
Target ratio: 0.5-2.0 test lines per production line DORA Capability AssessmentArchetype: mixed-signals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.