Skip to content

Improvements to Bengali Streamlit translation#17

Open
jojo96 wants to merge 48 commits into
streamlit:masterfrom
jojo96:master
Open

Improvements to Bengali Streamlit translation#17
jojo96 wants to merge 48 commits into
streamlit:masterfrom
jojo96:master

Conversation

@jojo96

@jojo96 jojo96 commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

Hello

Thank you very much for accepting my contributions.
Could you address the following minor issues:

Day2.md is not yet translated, could you help to translate this?
In Day27.md, the bottom link has an extra space in the middle of the link (Line 269). Thus, please delete the extra space

I addressed both of these issues.

Hi again Ujjayanta,
Could you re-deploy the app and make sure that it is set to Public, it is currently not public.
Thanks!

I am not sure about this. I just deployed the app from share.streamlit.io and the link is https://jojo96-30days-bengali-streamlit-app-cy9uyl.streamlit.app/

Should it do the trick?

@jojo96 jojo96 closed this Mar 24, 2023
@jojo96

jojo96 commented Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

I made the changes and also another minor change to the streamlit_app.py in the repo but could you check if all the necessary things are done?
Thank you for the help

@jojo96 jojo96 reopened this Mar 24, 2023
@dataprofessor

Copy link
Copy Markdown
Contributor

Hi Ujjayanta,
Many thanks for the rapid efforts in remedying the suggested comments.
I've cloned your repo and re-deployed at https://30days-in-bengali.streamlit.app/
I can up the resource for this URL so that it can handle more traffic.

In the meantime, we'll also create a mirror repo on the official Streamlit account (cloned from your main repo).

Best regards,
Chanin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants