Improvements to Bengali Streamlit translation#17
Open
jojo96 wants to merge 48 commits into
Open
Conversation
Contributor
Author
|
I made the changes and also another minor change to the streamlit_app.py in the repo but could you check if all the necessary things are done? |
Contributor
|
Hi Ujjayanta, In the meantime, we'll also create a mirror repo on the official Streamlit account (cloned from your main repo). Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
Thank you very much for accepting my contributions.
Could you address the following minor issues:
Day2.md is not yet translated, could you help to translate this?
In Day27.md, the bottom link has an extra space in the middle of the link (Line 269). Thus, please delete the extra space
I addressed both of these issues.
Hi again Ujjayanta,
Could you re-deploy the app and make sure that it is set to Public, it is currently not public.
Thanks!
I am not sure about this. I just deployed the app from share.streamlit.io and the link is https://jojo96-30days-bengali-streamlit-app-cy9uyl.streamlit.app/
Should it do the trick?