index-builder: include block number, ID and payload type in unmarshalling errors#149
Open
YaroShkvorets wants to merge 3 commits into
Open
Conversation
This was referenced Jun 6, 2026
YaroShkvorets
force-pushed
the
improve/index-builder-unmarshal-error
branch
from
c7d9ce6 to
f2d60aa
Compare
Contributor
|
If rebased, checks should pass now for external contributions |
…ling errors Previously a corrupt block payload surfaced as a bare 'proto: cannot parse invalid wire-format data' with no indication of which block or merged-blocks bundle was at fault, forcing operators to scan the whole store to find it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
YaroShkvorets
force-pushed
the
improve/index-builder-unmarshal-error
branch
from
cad9390 to
0807ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the
index-builderapp hits a block whose payload fails to unmarshal, it dies with:There is no indication of which block or which merged-blocks bundle is at fault, forcing the operator to
fireeth tools check merged-blocks -fthe whole store to locate it. We hit this in production on a MegaETH deployment (single corrupted block deep inside an otherwise-healthy bundle).Change
Wrap the payload unmarshalling error in the index-builder block handler with the block number, block ID and payload type URL:
The block number directly identifies the offending bundle file.
🤖 Generated with Claude Code