fix(api): drop stale publish-no-media rule and pinning test#515
fix(api): drop stale publish-no-media rule and pinning test#515staging-devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The publish-no-media rule was documented in the client_lint rustdoc but never implemented — its surface is already covered by the empty-tracks rule. The rustdoc was cleaned up in b5c2eae, but the pinning test remained. - Remove the publish_no_media_rule_is_not_emitted pinning test from client_lint.rs (no longer needed since the doc no longer claims the rule exists). - Rename test_lint_publish_no_media to test_lint_empty_tracks in tests.rs to match the actual rule it validates. Closes #473 Signed-off-by: streamkit-devin <devin@streamkit.dev>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
| fn test_lint_empty_tracks() { | ||
| let mut c = dynamic_client(); | ||
| c.publish = Some(PublishConfig { broadcast: "x".into(), tracks: vec![] }); | ||
| let warnings = lint_client_section(&c, EngineMode::Dynamic); |
There was a problem hiding this comment.
📝 Info: Deleted regression test overlapped with the renamed empty-tracks coverage
The removed client_lint.rs unit test only asserted that a normal publish config with one track does not emit the obsolete publish-no-media rule. Since the lint implementation emits empty-tracks only when publish.tracks.is_empty() (crates/api/src/yaml/client_lint.rs:169-175), the renamed test here continues to cover the active behavior for empty publish configurations. A repository-wide search found no remaining publish-no-media references, so this looks like test cleanup rather than a behavioral change that needs a bug finding.
(Refers to lines 847-851)
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 79.39% 79.40% +0.01%
==========================================
Files 232 232
Lines 66904 66883 -21
Branches 1909 1909
==========================================
- Hits 53117 53109 -8
+ Misses 13781 13768 -13
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2 participants
Summary
publish-no-mediarule was documented in thelint_client_sectionrustdoc but never implemented — its surface is covered by theempty-tracksrule. The rustdoc was cleaned up in b5c2eae, but the pinning testpublish_no_media_rule_is_not_emittedremained.client_lint.rs.test_lint_publish_no_media→test_lint_empty_tracksintests.rsto match the actual rule it validates.Closes #473
Review & Validation
just lintandcargo test -p streamkit-apipass with no regressions.Link to Devin session: https://staging.itsdev.in/sessions/65938fd28fa94a968db2a17d67954a4e
Requested by: @streamer45
Devin Review
7a66ff7