Skip to content

add fallback pools with individual user identities#205

Merged
GitGab19 merged 1 commit into
stratum-mining:mainfrom
GitGab19:fallback-pools
Jul 9, 2026
Merged

add fallback pools with individual user identities#205
GitGab19 merged 1 commit into
stratum-mining:mainfrom
GitGab19:fallback-pools

Conversation

@GitGab19

@GitGab19 GitGab19 commented Jul 7, 2026

Copy link
Copy Markdown
Member

Alternative to #119

Closes #45

Screenshot From 2026-07-07 20-29-56 Screenshot From 2026-07-07 21-47-07

@pavlenex

pavlenex commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Good direction! Is there a reason why username needs to be asked on 3 places?
Screenshot 2026-07-08 at 18 32 50

Also should we add a vailidation that it needs to be a bitcoin address if text says it's "usually" a bitcoin address?

@GitGab19

GitGab19 commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Is there a reason why username needs to be asked on 3 places?

I made it work in that way to have guarantees about users properly setting the usernames they want for each pool they want to configure as fallback.

Also should we add a vailidation that it needs to be a bitcoin address if text says it's "usually" a bitcoin address?

Validation is already in place:
image

@pavlenex

pavlenex commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I don't mean per pool, check the screenshot, besides username for each pool on this page we ask user 2 more times for the username.
618833197-0ba87244-fee1-4110-b3df-e4dc8fc53f14

It's also odd that something user needs to submit, such as username now gets below the fold. Can't we have username in a different step?

@pavlenex

pavlenex commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I would also consider having fallback pool as a separate step, optional, this step now is too convoluted imo, we need to think more on the design pattern here. Let me play around a bit to see if we can have better UX here.

@GitGab19

GitGab19 commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Squashed @pavlenex commit, now the pool selection looks like this:

image image image

@lucasbalieiro

Copy link
Copy Markdown
Collaborator

the input is loosing focus on every char typed

Screen.Recording.2026-07-09.at.00.16.04.mov

Comment thread src/lib/miningIdentity.ts Outdated
Comment thread src/components/setup/steps/MiningIdentityStep.tsx
@GitGab19

GitGab19 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@lucasbalieiro, I just tackled all your three points.

Require `user_identity` on each primary/fallback pool, generate ordered fallback upstreams, and migrate legacy translator/JDC identities into pool configs. Update setup and settings to collect usernames per pool, support SRI donation identities, and manage fallback pools with ordering and logos.

@lucasbalieiro lucasbalieiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

the upstreams are being correctly ordered and applied in the config file:

image

@GitGab19 GitGab19 merged commit 0b57060 into stratum-mining:main Jul 9, 2026
5 checks passed
@GitGab19 GitGab19 deleted the fallback-pools branch July 9, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability for users to add multiple fallback pools through the UI

3 participants