Shutdown centralized in Pool runtime flow#613
Merged
Shourya742 merged 1 commit intoJul 14, 2026
Merged
Conversation
Shourya742
force-pushed
the
2026-07-13-add-failure-state-to-pool-runtime
branch
from
62e43ea to
d246b06
Compare
Member
|
@nulllpc do you want to have a look at this? |
Contributor
|
LGTM, the comments also match with the new logic. Thanks for cleaning up the redundant |
nulllpc
approved these changes
Jul 13, 2026
plebhash
approved these changes
Jul 13, 2026
Shourya742
force-pushed
the
2026-07-13-add-failure-state-to-pool-runtime
branch
from
d246b06 to
fe72141
Compare
1. Add fail state in type state transition 2. Correct the visibility of methods 3. We had to Bootstrap_error just to avoid orphan rule
Shourya742
force-pushed
the
2026-07-13-add-failure-state-to-pool-runtime
branch
from
fe72141 to
e9ccbbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#582 (comment)