Skip to content

introduce shared modules to bitcoin_core_sv2#602

Merged
Shourya742 merged 6 commits into
stratum-mining:mainfrom
plebhash:2026-07-07-bitcoin-core-sv2-shared-modules
Jul 14, 2026
Merged

introduce shared modules to bitcoin_core_sv2#602
Shourya742 merged 6 commits into
stratum-mining:mainfrom
plebhash:2026-07-07-bitcoin-core-sv2-shared-modules

Conversation

@plebhash

@plebhash plebhash commented Jul 7, 2026

Copy link
Copy Markdown
Member

close #574

@plebhash plebhash force-pushed the 2026-07-07-bitcoin-core-sv2-shared-modules branch from 6575eee to 1862daa Compare July 7, 2026 23:48
@Sjors

Sjors commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I'm always a fan of de-duplication. If this lands before #600 it will make e0647db test: add Bitcoin Core master IPC bindings a bit shorter.

@plebhash plebhash force-pushed the 2026-07-07-bitcoin-core-sv2-shared-modules branch 2 times, most recently from 8906f16 to d91e829 Compare July 9, 2026 17:54
@plebhash plebhash marked this pull request as ready for review July 9, 2026 17:54
@plebhash plebhash requested a review from GitGab19 July 9, 2026 17:54
@plebhash plebhash added this to the sv2-apps 📱 v0.7.0 milestone Jul 9, 2026
@plebhash

plebhash commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

ready for review

@plebhash plebhash force-pushed the 2026-07-07-bitcoin-core-sv2-shared-modules branch from d91e829 to e957cc5 Compare July 9, 2026 20:34
@plebhash plebhash force-pushed the 2026-07-07-bitcoin-core-sv2-shared-modules branch from e957cc5 to 3f62871 Compare July 9, 2026 20:37
@github-project-automation github-project-automation Bot moved this to Todo 📝 in sv2-apps 📱 Jul 10, 2026
@GitGab19 GitGab19 moved this from Todo 📝 to Ready For Review 🔍 in Stratum V2 - 2026 Q2 - Roadmap 📍🗺️ Jul 10, 2026
@GitGab19 GitGab19 removed this from sv2-apps 📱 Jul 10, 2026
@GitGab19 GitGab19 removed this from the sv2-apps 📱 v0.7.0 milestone Jul 10, 2026
Comment thread bitcoin-core-sv2/src/unix_capnp/v31x_v30x/mod.rs
@Shourya742 Shourya742 self-requested a review July 10, 2026 13:57
Comment thread pool-apps/pool/src/lib/channel_manager/mod.rs Outdated
@plebhash plebhash force-pushed the 2026-07-07-bitcoin-core-sv2-shared-modules branch from 3f62871 to 0ac999d Compare July 13, 2026 14:56
@plebhash plebhash force-pushed the 2026-07-07-bitcoin-core-sv2-shared-modules branch from 0ac999d to a942d6f Compare July 13, 2026 16:28
@Shourya742 Shourya742 merged commit a712d64 into stratum-mining:main Jul 14, 2026
11 checks passed
@plebhash plebhash deleted the 2026-07-07-bitcoin-core-sv2-shared-modules branch July 14, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

need shared modules on bitcoin_core_sv2 to avoid code duplication

4 participants