fix: add default timeout to http_request to prevent indefinite blocking#474
Open
wangwangbobo wants to merge 2 commits into
Open
fix: add default timeout to http_request to prevent indefinite blocking#474wangwangbobo wants to merge 2 commits into
wangwangbobo wants to merge 2 commits into
Conversation
The http_request tool was calling session.request() without a timeout parameter. The Python requests library defaults to no timeout, so a non-responsive server would block the agent indefinitely. Changes: - Add timeout to TOOL_SPEC input schema (default: 30 seconds) - Set default timeout on session.request() call - Allow per-request timeout override via input
Author
|
This is a solid fix — the default 30s timeout prevents indefinite blocking. LGTM, no nitpicks. |
|
Can we add a unit test to the PR? |
- test_default_timeout: verifies default 30s timeout is applied - test_custom_timeout: verifies custom timeout overrides default - test_timeout_default_value_passed_to_request: verifies timeout=30 is actually passed to session.request - test_custom_timeout_value_passed_to_request: verifies custom timeout value is correctly propagated
Author
|
hey @notowen333, good call — just pushed 4 unit tests covering the default timeout behavior:
ran into a network blip pushing the branch, should land shortly! |
Author
|
pushed the tests — 4 test cases covering default timeout, custom timeout, and verifying the value actually reaches session.request. network was being slow earlier but it's up now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
http_requesttool was callingsession.request()without atimeoutparameter. The Pythonrequestslibrary defaults to no timeout, so a non-responsive server would block the agent indefinitely.Changes
timeouttoTOOL_SPECinput schema (default: 30 seconds)session.request()callCode Changes
Testing
The fix is minimal and non-breaking:
timeoutparameterRelated Issue
Closes #442 - bug: http_request tool has no request timeout