Skip to content

Cargo.toml: cookie-factory: disable default features, use "std" only#636

Open
deadbaed wants to merge 1 commit into
str4d:mainfrom
deadbaed:push-qkkuwnuqkrrn
Open

Cargo.toml: cookie-factory: disable default features, use "std" only#636
deadbaed wants to merge 1 commit into
str4d:mainfrom
deadbaed:push-qkkuwnuqkrrn

Conversation

@deadbaed

Copy link
Copy Markdown

The features ["std", "async"] are enabled by default, but inside the crates async code of cookie-factory is never used.

Here's the diff when running cargo tree:

65,89d64
< │   │   └── futures v0.3.32
< │   │       ├── futures-channel v0.3.32
< │   │       │   ├── futures-core v0.3.32
< │   │       │   └── futures-sink v0.3.32
< │   │       ├── futures-core v0.3.32
< │   │       ├── futures-executor v0.3.32
< │   │       │   ├── futures-core v0.3.32
< │   │       │   ├── futures-task v0.3.32
< │   │       │   └── futures-util v0.3.32
< │   │       │       ├── futures-channel v0.3.32 (*)
< │   │       │       ├── futures-core v0.3.32
< │   │       │       ├── futures-io v0.3.32
< │   │       │       ├── futures-macro v0.3.32 (proc-macro)
< │   │       │       │   ├── proc-macro2 v1.0.106 (*)
< │   │       │       │   ├── quote v1.0.46 (*)
< │   │       │       │   └── syn v2.0.118 (*)
< │   │       │       ├── futures-sink v0.3.32
< │   │       │       ├── futures-task v0.3.32
< │   │       │       ├── memchr v2.8.3
< │   │       │       ├── pin-project-lite v0.2.17
< │   │       │       └── slab v0.4.12
< │   │       ├── futures-io v0.3.32
< │   │       ├── futures-sink v0.3.32
< │   │       ├── futures-task v0.3.32
< │   │       └── futures-util v0.3.32 (*)
253c228
< ├── cookie-factory v0.3.3 (*)
---
> ├── cookie-factory v0.3.3
526c501,510
< │   ├── futures-executor v0.3.32 (*)
---
> │   ├── futures-executor v0.3.32
> │   │   ├── futures-core v0.3.32
> │   │   ├── futures-task v0.3.32
> │   │   └── futures-util v0.3.32
> │   │       ├── futures-core v0.3.32
> │   │       ├── futures-io v0.3.32
> │   │       ├── futures-task v0.3.32
> │   │       ├── memchr v2.8.3
> │   │       ├── pin-project-lite v0.2.17
> │   │       └── slab v0.4.12
528c512,515
< │   ├── futures-macro v0.3.32 (proc-macro) (*)
---
> │   ├── futures-macro v0.3.32 (proc-macro)
> │   │   ├── proc-macro2 v1.0.106 (*)
> │   │   ├── quote v1.0.46 (*)
> │   │   └── syn v2.0.118 (*)

The big red block is for the usage of cookie-factory in age-core crate.

The green blocks is because futures-test (used as a dev-dependency in the age crate) uses those crates.

The features ["std", "async"] are enabled by default, but inside the
crates async code of cookie-factory is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant