fix: throw if address for chainId is missing#704
Merged
Conversation
Ocheretovich
requested review from
LeoHChen,
allenchuang,
barry-peng-story,
jacob-tucker,
limengformal,
lucas2brh,
roycezhaoca and
yingyangxu2026
as code owners
Collaborator
|
Thank you for your interest in our project. I'm curious why you're interested in this part of the code? This section of code is not exposed to users, and internally we will not map chainId to invalid addresses. |
Contributor
Author
|
While reviewing the code I noticed that address[chainId] could return undefined. Throwing an explicit error felt safer than silently returning an undefined value. |
Collaborator
|
get it, I will communicate with other to decide whether merge the PR. |
lucas2brh
approved these changes
Mar 10, 2026
yingyangxu2026
approved these changes
Mar 10, 2026
Collaborator
|
@Ocheretovich Commits must have verified signatures. |
Signed-off-by: Ocheretovich Oksana <ocheretovich@gmail.com>
Contributor
Author
|
@yingyangxu2026 signed and force-pushed the commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent getAddress from returning undefined when a mapping for the given chainId is missing. Adds a small fail-fast guard to throw an explicit error instead of returning an undefined address.