Fix inverting absolute vs. relative precision for lra#929
Open
tquatmann wants to merge 1 commit into
Open
Conversation
Contributor
|
Not sure why the tests fail? |
Contributor
Author
|
The problem seems to be that in at least one of the tests we compute the minimal expected LRA value for a MEC, where the true solution is 0. This is problematic with relative precision, because that essentially means we cannot make approximation errors. Specifically, the MEC in our case does have positive rewards on some transition, but it contains another (sub-)EC for which all transitions have zero reward. I'm not sure yet, what to do about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #915