String and string array fixes#513
Open
RobertoRoos wants to merge 5 commits into
Open
Conversation
# Conflicts: # tests/test_connection_class.py
…nstead of a single character
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreation of faulty PR:
Trying to improve string handling to solve some of the open issues.
Frankly I'm a bit lost what the issues are exactly, I'm trying to go through them slowly.EDIT: Okay, I think this is about it for now. I think this resolves all string issues?Resolves:
parse_notification#409Should resolve (but I haven't reproduced the issue before):
Obsoletes other PRs: