fix: align sidebar, select, and password-meter to their surfaces#568
Merged
Conversation
Light mode showed hovered and selected rows at the same full sidebar-accent, so hovering an item looked identical to the active one. Apply the existing dark-mode treatment (bg-sidebar-accent/50 for non-active hover) in light mode too, and flatten the reveal-overlay token to the matching opaque colour.
The select viewport had no padding, so its rounded items sat flush against the container edge while the dropdown-menu insets its items. Add matching padding so both dropdowns look consistent.
The segment gaps used ring-background, which only matches the surface when the page background equals the card colour. The meter always sits inside a card, so ring-card is correct in both modes (light previously hardcoded ring-background).
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
saas-starter | c023849 | Commit Preview URL Branch Preview URL |
Jun 15 2026, 11:11 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small surface/theme issues that are easy to miss with the default zinc theme but show up in forks that customise the background or card colours.
The select dropdown rendered its rounded items flush against the container edge because the viewport had no padding, unlike the dropdown-menu which insets its items. The select viewport now uses matching padding so both dropdowns look consistent. This one is visible in the default theme too.
The sidebar showed hovered and selected rows at the same full sidebar-accent in light mode, so hovering an item looked identical to the active one. The dark-mode treatment already softened non-active hover to a half-opacity accent; that now applies in light mode too, and the reveal-overlay token is flattened to the matching opaque colour so the shortcut overlay still lines up with the row.
The password strength meter drew its segment gaps with ring-background, which only matches the surface when the page background equals the card colour. The meter always sits inside a card, so it now uses ring-card in both modes. No visual change with the default theme where background and card are both white, but it fixes forks with a tinted page background.
No visual change to the default theme except the select padding and the softer light-mode sidebar hover.
Regression guard: not warranted, these are CSS-only class tweaks (hover opacity, dropdown padding, ring surface) with no logic or data contract a test could pin without brittle pixel snapshots.