Skip Convex env validation when deploy key can't list vars#563
Open
stickerdaniel wants to merge 1 commit into
Open
Skip Convex env validation when deploy key can't list vars#563stickerdaniel wants to merge 1 commit into
stickerdaniel wants to merge 1 commit into
Conversation
Convex deploy keys can deploy but are denied ViewEnvironmentVariables, so `convex env list` fails in CI under deploy-key auth and blocks production builds for forks using deployment-scoped deploy keys. Skip the pre-flight validation on a permission error instead of failing; the deploy still runs and missing vars surface at runtime.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
saas-starter | fbed1a8 | Commit Preview URL Branch Preview URL |
Jun 15 2026, 01:12 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convex deploy keys can deploy but are denied
ViewEnvironmentVariables, soscripts/validate-convex-env.ts(which runsconvex env list) fails in CI whenever the build authenticates with a deployment-scoped deploy key. A leaked deploy key must not be able to read secret values, so this is by design on Convex's side. The pre-flight check then hard-fails the production build.This skips the validation when
convex env listfails with a permission error, logging the required var names instead of failing the build. The deploy still runs, and a genuinely missing var surfaces at runtime. Validation still works wherever the auth can read env vars (local dev, project-level keys).bun scripts/static-checks.ts scripts/validate-convex-env.tspasses.