Email notification for cert expiry by garaimanoj · Pull Request #204 · stfc/CAPortal

garaimanoj · 2026-04-24T15:00:05Z

2026-04-27T09:57:00.193+01:00  INFO 423739 --- [iry-scheduler-1] uk.ac.ngs.TaskConfig                     : Starting daily certificate expiry reminder job
2026-04-27T09:57:00.461+01:00  INFO 423739 --- [iry-scheduler-1] uk.ac.ngs.service.CertificateService     : 1 certificate(s) are going to expire after 7 days.
2026-04-27T09:57:00.463+01:00  INFO 423739 --- [iry-scheduler-1] uk.ac.ngs.service.CertificateService     : Sending 7-days expiry reminder for cert [103] to bob13@xyzc.com
2026-04-27T09:57:02.053+01:00  INFO 423739 --- [iry-scheduler-1] u.a.n.s.email.FreemarkerEmailSender      : body=<!doctype html>

<html>

<body>
    Dear Owner of UK e-Science Certificate number: 103,
    <br />
    <br />
    You have a certificate which will expire in <b>7 days</b>. If you do not wish to renew this
    certificates or if you have
    done so already then please ignore this message.
    <br />
    <br />
    Your certificate was issued for "User3" and has the subject:
    <br />
    <br />
    [CN=User1,OU=xyz_c,O=stfc.com,L=OX,ST=OX,C=UK]
    <br />
    <br />
    If you prefer a browser interface for your certificate management and you have your current certificate in your
    browser then please go to the CA Portal <a href="https://portal.ca.grid-support.ac.uk/">https://portal.ca.grid-support.ac.uk/</a> and follow the instructions
    for renewal.
    <br />
    <br />
    Other tools are available at <a href="https://ca.grid-support.ac.uk">https://ca.grid-support.ac.uk</a>
    <br />
    <br />
    The server will then queue your renewal request for your RA to approve.
    There is NO need to visit your RA. You will receive an e-mail when the certificate is available.
    <br />
    <br />
    If you have any questions, concerns or comments, then we shall be pleased to hear them. We are always aiming to
    improve our service, and so your feedback will be appreciated.
    <br />
    <br />
    Regards,
    <br />
    <br />
    The UK eScience CA Support Centre
</body>

</html>
2026-04-27T09:57:02.637+01:00 ERROR 423739 --- [iry-scheduler-1] uk.ac.ngs.service.email.EmailService     : MailSender Failed messages: org.eclipse.angus.mail.smtp.SMTPSendFailedException: 530-5.7.0 Must issue a STARTTLS command first. For more information, go to
530-5.7.0  https://support.google.com/a/answer/3221692 and review RFC 3207
530 5.7.0 specifications. 5b1f17b1804b1-488fb74c789sm233860095e9.5 - gsmtp

2026-04-27T09:57:02.642+01:00  INFO 423739 --- [iry-scheduler-1] uk.ac.ngs.service.CertificateService     : No certificates are going to expire after 30 days.
2026-04-27T09:57:02.643+01:00  INFO 423739 --- [iry-scheduler-1] uk.ac.ngs.TaskConfig                     : Completed daily certificate expiry reminder job successfully in 2448 ms

Sample email in html

garaimanoj · 2026-04-27T08:36:50Z

+        long endOfDay = Long.parseLong(
+                formatter.format(targetDate.plusDays(1)
+                                .atStartOfDay(ZoneOffset.UTC)));


yyyyMMddHHmmss produces only digits → safe to parse as long

garaimanoj · 2026-05-06T11:55:08Z

+        long startOfDay = Long.parseLong(
+                formatter.format(targetDate.atStartOfDay(ZoneOffset.UTC)));


yyyyMMddHHmmss produces only digits → safe to parse as long

…minderTemplate.html Co-authored-by: rowan04 <rowanmoss04@gmail.com>

DonaldChung-HK

Hi @garaimanoj, thanks for writing the feature, just a small bit of monitoring so that we can spot and diagnose issue of missing email more easily in the future (just being a bit cautious since it is possible that the issue is from the Postgres DB.)

DonaldChung-HK · 2026-05-18T09:24:34Z

+            certificateService.sendCertificateExpiryReminders();
+
+            long durationMs = System.currentTimeMillis() - startTime;
+            log.info("Completed daily certificate expiry reminder job successfully in {} ms",


Maybe a summary of number of SMTP mail pushed for 30 day and 7 day reminder as well so that we can spot the anomaly by comparing this number and expected number from DB. Thanks

Done
Summary for 7-day expiry reminder (processingDate=2026-05-19): total=1, sent=0, failed=1

DonaldChung-HK · 2026-05-18T09:29:15Z

+        try {
+            this.mailSender.send(msg, vars, this.emailUserCertExpiryReminderTemplate);
+        } catch (MailException ex) {
+            log.error("MailSender " + ex.getMessage());
+        }


Maybe a log for CN (that can be toggled on/off) here for monitoring purposes so we know what did or did not get sent successfully to the SMTP server.

DonaldChung-HK

Thanks for adding the logging function. Looks good.

rowan04

lgtm after this small change!

rowan04 · 2026-05-19T15:34:27Z

+            if(this.emailService.sendEmailReminderToUserOnCertExpiry(cert, daysToExpire)){
+                successCount++;
+            } else{


Suggested change

if(this.emailService.sendEmailReminderToUserOnCertExpiry(cert, daysToExpire)){

successCount++;

} else{

if (this.emailService.sendEmailReminderToUserOnCertExpiry(cert, daysToExpire)) {

successCount++;

} else {

Thanks, good spot on the formatting.

Email notification for cert expiry

9880286

garaimanoj self-assigned this Apr 24, 2026

github-advanced-security AI found potential problems Apr 24, 2026

View reviewed changes

Add email subject

7068a1f

github-advanced-security AI found potential problems Apr 27, 2026

View reviewed changes

Add tests and get schedule time from property file

74dbe7e

github-advanced-security AI found potential problems May 11, 2026

View reviewed changes

garaimanoj added 2 commits May 12, 2026 16:30

Catch up with failed cert reminder

1158d37

Update java doc for sendEmailReminderToUserOnCertExpiry

048587e

garaimanoj requested a review from DonaldChung-HK May 13, 2026 07:37

garaimanoj marked this pull request as ready for review May 13, 2026 07:37

Add comment

2bcee65

rowan04 reviewed May 13, 2026

View reviewed changes

Comment thread src/main/webapp/WEB-INF/freemarker/email/emailUserCertExpiryReminderTemplate.html Outdated

Comment thread src/main/webapp/WEB-INF/freemarker/email/emailUserCertExpiryReminderTemplate.html Outdated

garaimanoj and others added 2 commits May 13, 2026 16:32

Update src/main/webapp/WEB-INF/freemarker/email/emailUserCertExpiryRe…

cccf4c5

…minderTemplate.html Co-authored-by: rowan04 <rowanmoss04@gmail.com>

Update src/main/webapp/WEB-INF/freemarker/email/emailUserCertExpiryRe…

e5828e9

…minderTemplate.html Co-authored-by: rowan04 <rowanmoss04@gmail.com>

garaimanoj requested a review from rowan04 May 13, 2026 15:32

DonaldChung-HK reviewed May 18, 2026

View reviewed changes

Add reminder summary log

3eb7f63

garaimanoj requested a review from DonaldChung-HK May 19, 2026 14:39

DonaldChung-HK approved these changes May 19, 2026

View reviewed changes

rowan04 reviewed May 19, 2026

View reviewed changes

Format code

4608284

garaimanoj requested a review from rowan04 May 20, 2026 07:26

rowan04 approved these changes May 20, 2026

View reviewed changes

		long startOfDay = Long.parseLong(
		formatter.format(targetDate.atStartOfDay(ZoneOffset.UTC)));

Conversation

garaimanoj commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

garaimanoj Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

garaimanoj May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DonaldChung-HK left a comment

Choose a reason for hiding this comment

Uh oh!

DonaldChung-HK May 18, 2026

Choose a reason for hiding this comment

Uh oh!

garaimanoj May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DonaldChung-HK May 18, 2026

Choose a reason for hiding this comment

Uh oh!

garaimanoj May 19, 2026

Choose a reason for hiding this comment

Uh oh!

DonaldChung-HK left a comment

Choose a reason for hiding this comment

Uh oh!

rowan04 left a comment

Choose a reason for hiding this comment

Uh oh!

rowan04 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

garaimanoj May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

garaimanoj commented Apr 24, 2026 •

edited

Loading

garaimanoj May 19, 2026 •

edited

Loading