fix(sdk): parse structured AI assessments#10
Open
TimeToBuildBob wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SDKs
AssessCode()andBatchAssessCode()returnCodeAssessmentwith always-emptyIssuesandRecommendationsfields, despite the model producing structured output. The SDK docs and example worker branch on these empty fields, encouraging dead control flow.Changes
internal/discovery/sdk/ai.go: BothAssessCode()andBatchAssessCode()now request raw JSON output and parse it using the existinginternal/aiJSON parsing utilities.internal/discovery/sdk/ai_internal_test.go: New package-local tests covering direct JSON parsing, fenced JSON, batch snippet ID preservation, and malformed/missing/duplicate batch results.CodeAssessmentfields:Issues,Recommendations, andConfidencenow come from real model output instead of empty placeholders.Verification
go test ./internal/discovery/sdkCloses #... (no issue opened for this, it was a scout finding)