fix out-of-bounds read in jmespath negative-step slice#2670
Open
uwezkhan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_slice's read-all fallback clamps the slice with wrap_index, which returns a value in [0, size]. For a negative step the loop starts at value[start_idx] and walks down, so a start index at or past the array length (
[5:0:-1]on a 3-element array) readsvalue[size], one byte-region past the end. That same loop compacts in place while reading in reverse, so the ascending write index also clobbers elements the descending read has not reached, and[4:0:-1]over[1,2,3,4,5]returned[5,4,3,4]instead of[5,4,3,2].Positive steps keep the in-place compaction since the write index never overtakes the read index. The negative step now builds the slice in a separate buffer and starts no later than the last element, which drops both the over-read and the aliasing at the cost of one temporary allocation. Behavior matches the usual
[start:stop:-1]slice ([10:0:-1]over five elements gives[5,4,3,2]).