CI workflow for MSVC O2#2590
Merged
stephenberry merged 3 commits intoJun 1, 2026
Merged
Conversation
Owner
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that glaze uses
asio::awaitablein its code, and immediately recalled a time debugging a crash on O2 caused byasio::co_composed, and even though I didn’t see any use ofasio::co_composed_futurein glaze - I thought it wouldn’t hurt to add an extra check for the O2 build for MSVC, because it's probably one of the most finicky compilers out there.Motivation is my recent very negative experience with the MSVC optimizer: chriskohlhoff/asio#1724.
In short, MSVC emitted an aligned 128-bit
movaps, even though the operand address was aligned to 8 bytes, not 16, so this resulted inSTATUS_ACCESS_VIOLATION