chore: fix lint warnings in VAD, AEC, and stateless adapter#10
Merged
Conversation
Collaborator
|
Thanks for the contribution! To get this ready to merge:
Full conventions: |
github-actions
Bot
added
area/docs
Clears the oxlint warnings surfaced by `pnpm check` without touching the frozen README/.gitignore files (AGENTS.md §7): - Replace `new Array(length)` sparse-array construction in the VAD edit-distance helpers (cli-handlers.ts, resolver.ts) with `Array.from`, avoiding holey arrays. - Drop the unused `catch (e)` binding in the stateless backend adapter. - Use arrow functions in the browser AEC async iterator to avoid `const self = this` aliasing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pingfanfan
force-pushed
the
chore/clean-checks
branch
from
June 18, 2026 11:34
5628a45 to
193781e
Compare
pingfanfan
changed the title
Contributor
|
Hi @pingfanfan, thanks for the lint cleanup. This PR overlaps with #41 and #68 on the VAD sparse array fix (cli-handlers.ts, resolver.ts) and the unused catch parameter in stepfun-stateless.ts. Those PRs are currently open and cover the same files. Wanted to flag the overlap in case you want to coordinate or consolidate. |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Why
pnpm checksurfaced several low-riskoxlintwarnings on a fresh checkout. This PR clears them.Per
AGENTS.md§7,README.md,README_CN.md, and.gitignoreare currently frozen, so this PR touches code only — the markdown/.gitignorechanges from the earlier revision have been dropped (and were already addressed onmain).What changed
cli-handlers.ts,resolver.ts): replacenew Array(length)sparse-array construction withArray.from, avoiding holey arrays.stepfun-stateless.ts): drop the unusedcatch (e)binding.browser-audio-driver.ts): use arrow functions to avoidconst self = thisaliasing.Verification
pnpm checkexits 0 (test + lint + dep-guard + deadcode + tsc + prettier) —1475tests pass.main; no conflicts.