Skip to content

Fix crash when trying to load animated WebP, return dummy matrix#19

Open
jaakkor2 wants to merge 5 commits into
stemann:masterfrom
jaakkor2:crashfix
Open

Fix crash when trying to load animated WebP, return dummy matrix#19
jaakkor2 wants to merge 5 commits into
stemann:masterfrom
jaakkor2:crashfix

Conversation

@jaakkor2
Copy link
Copy Markdown

@jaakkor2 jaakkor2 commented Apr 8, 2026

Fix crash reported in #18. Returns a dummy matrix of the size of the webp, fulfilling needs of ASML-Labs/PPTX.jl#78.

Could be improved with a test, loading the first frame instead a place holder, but hopefully fixing the crash is enough for a merge and a release of a new version.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.19%. Comparing base (b8a91f2) to head (ebbcbe1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   32.25%   34.19%   +1.93%     
==========================================
  Files           5        5              
  Lines         341      348       +7     
==========================================
+ Hits          110      119       +9     
+ Misses        231      229       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stemann
Copy link
Copy Markdown
Owner

stemann commented Apr 8, 2026

Thanks! Yes, we should be able to make a patch release.

I would very much like a test to be added.

@jaakkor2
Copy link
Copy Markdown
Author

jaakkor2 commented Apr 8, 2026

Looks like https://developers.google.com/speed/webp/gallery does not contain examples of animated webp. Then maybe one could rely on https://mathiasbynens.be/demo/animated-webp-supported.webp to be available for downloading for tests?

@stemann
Copy link
Copy Markdown
Owner

stemann commented Apr 8, 2026

It seems https://developers.google.com/speed/webp/faq has a tiny base64 encoded webp image with animation and https://storage.googleapis.com/downloads.webmproject.org/webp/images/dancing_banana2.lossless.webp

@jaakkor2
Copy link
Copy Markdown
Author

jaakkor2 commented Apr 8, 2026

Animated webp file added to tests.

@stemann
Copy link
Copy Markdown
Owner

stemann commented Apr 9, 2026

Please rebase on master (updated CI), and fix formatting issues.

@jaakkor2
Copy link
Copy Markdown
Author

All checks have passed. Anything else that is needed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants