Fix crash when trying to load animated WebP, return dummy matrix#19
Fix crash when trying to load animated WebP, return dummy matrix#19jaakkor2 wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 32.25% 34.19% +1.93%
==========================================
Files 5 5
Lines 341 348 +7
==========================================
+ Hits 110 119 +9
+ Misses 231 229 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! Yes, we should be able to make a patch release. I would very much like a test to be added. |
|
Looks like https://developers.google.com/speed/webp/gallery does not contain examples of animated webp. Then maybe one could rely on https://mathiasbynens.be/demo/animated-webp-supported.webp to be available for downloading for tests? |
|
It seems https://developers.google.com/speed/webp/faq has a tiny base64 encoded webp image with animation and https://storage.googleapis.com/downloads.webmproject.org/webp/images/dancing_banana2.lossless.webp |
|
Animated webp file added to tests. |
|
Please rebase on master (updated CI), and fix formatting issues. |
|
All checks have passed. Anything else that is needed here? |
Fix crash reported in #18. Returns a dummy matrix of the size of the webp, fulfilling needs of ASML-Labs/PPTX.jl#78.
Could be improved with a test, loading the first frame instead a place holder, but hopefully fixing the crash is enough for a merge and a release of a new version.