Stability fixes#389
Open
marta-lokhova wants to merge 1 commit into
Open
Conversation
Contributor
marta-lokhova
commented
May 28, 2026
- Properly spin up watchers when in pregenerated txs mode
- Upgrades: harden network limit calculation by including target block time in the calculation
- Fix SAC txSize estimate for network limits
- Fix broken support for simulate apply config flags
- Bump init delay timer. Previously, the lower limit would cause some containers to get killed sporadically on startup
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves stability for supercluster test missions by making initialization work correctly in simulate/pregenerated transaction modes, tuning startup liveness timing, and recalculating network limits based on target block time.
Changes:
- Re-enables stellar-core init commands during simulate-apply runs while keeping simulate-apply sleep settings out of init configs.
- Adds pregenerated transaction watcher setup for non-loadgen nodes.
- Reworks min-block-time network limit sizing to account for target close time and adjusts SAC transaction size estimates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/FSLibrary/StellarKubeSpecs.fs |
Increases liveness initial delay and allows init commands to run in simulate-apply mode. |
src/FSLibrary/StellarCoreCfg.fs |
Splits simulate-apply config behavior between init and main containers and adds trigger timer config. |
src/FSLibrary/MinBlockTimeTest.fs |
Updates pregenerated tx setup and target-time-based classic/Soroban limit calculations. |
src/FSLibrary/MaxTPSTest.fs |
Ensures non-loadgen nodes also run pregenerated tx initialization with zero txs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.