Add cap71 xdr#300
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds preliminary CAP-0071-related XDR definitions behind #ifdef CAP_0071 to allow experimenting with the proposed “XDR ifdefs” approach before the CAP is finalized.
Changes:
- Introduces delegate-signature credential structures and a new Soroban credentials enum/union variant under
CAP_0071. - Adds a new
EnvelopeTypeand correspondingHashIDPreimageunion arm for Soroban authorization that includes an address (underCAP_0071).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Stellar-transaction.x | Adds CAP-0071-gated Soroban credential structs/union variant and a new HashIDPreimage envelope arm. |
| Stellar-ledger-entries.x | Adds CAP-0071-gated EnvelopeType value for the new Soroban authorization-with-address envelope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dmkozh
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CAP-0071 XDR behind ifdefs. The XDR itself has not been finalized, but we're using the current proposal to try out the new XDR ifdefs.