Fix flakey binary fuse test

[SirTyson]

Description

Fixes flaky binary fuse filter test.

The bff has several "error" paths that force special behavior, that occur very rarely depending on hash collision patterns. We have a test that deterministically triggers one of these paths with random input. On some inputs, we actually naturally hit another special path, preventing us from hitting the path we care about in the test. Instead of adding a bunch more test only bypasses in the filter, I just modified the test to detect that this occurred and rotate the seed.

Checklist

• Reviewed the contributing document
• Rebased on top of master (no merge commits)
• Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
• Compiles
• Ran all tests
• If change impacts performance, include supporting evidence per the performance document

[Copilot]

Pull request overview

This PR updates the BinaryFuseFilter error-retry test to avoid CI flakiness caused by occasionally hitting a different rare “peeling failure retry” path before the intended forced “populate error retry” path.

Changes:

• Refactors test setup into a buildAndCheck(seed) helper that re-hashes keys for a given seed and validates membership.
• Makes the “one retry” section resilient by detecting unexpected peeling-retry hits and retrying the test with rotated seeds until the intended path is observed (or attempts are exhausted).