Create a Github workflow to check for the CAP status to warn on PR when adding functionality on CAPs that are not Accepted#5295
Draft
anupsdf wants to merge 1 commit into
Draft
Conversation
This reverts commit 9b29a9b. fix link
anupsdf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Create a Github workflow to check for status of the CAP before allowing changes to be merged. This is a non-blocking Github workflow that will warn on the PR if there are any
#ifdef CAP_XXXXguards being added in a fork PR and the corresponding CAP status in stellar-protocol repo is not in Accepted status.why
As per the CAP Process, only CAPs that are Accepted by the Core CAP committee can be implemented in stellar-core.