Add revoke sponsorship operation type literals#969
Open
chrisx9z wants to merge 1 commit into
Open
Conversation
Comment: Aligns revoke sponsorship TypeScript operation types with runtime subtype names.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds more granular TypeScript operation type literals for the various “revoke * sponsorship” helpers, and exercises them via new type-level tests.
Changes:
- Added distinct
OperationType.*string literal types for each revoke-sponsorship helper - Updated revoke-sponsorship operation interfaces to use those more specific discriminant
typevalues - Added type tests asserting
Operation.fromXDRObject(...)returns operations with the new specific.typeliterals
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| types/test.ts | Adds $ExpectType checks for the new revoke-sponsorship .type discriminants via fromXDRObject. |
| types/index.d.ts | Introduces new OperationType members and updates revoke-sponsorship operation interfaces to use them as discriminants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operation.typenames instead of the genericrevokeSponsorshipliteral.Operation.fromXDRObject.Fixes #728.
Verification
corepack yarn dtslint --localTs node_modules/typescript/lib types/node --check types/test.tsgit diff --check