Remove roles from secrets for github oidc and aws ecr#47
Merged
Conversation
Signed-off-by: Satyam Zode <satyamz@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes explicit AWS IAM role secret inputs from the Docker GitHub Actions workflow’s ECR public login step, relying on the stellar/actions/sdf-ecr-login composite action configuration instead.
Changes:
- Removed
aws-oidc-roleandaws-ecr-login-roleinputs from thesdf-ecr-loginstep. aws-regioninput was also removed from thesdf-ecr-loginstep (now relies on action defaults/behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jacekn
approved these changes
Mar 31, 2026
jacekn
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove roles from secrets for github oidc and aws ecr
Why
Composite action already has roles defined stellar/actions#99
Known limitations
NA