Skip to content

Packaging#5

Merged
stella-bourdin merged 29 commits into
stella-bourdin:mainfrom
leosaffin:packaging
May 18, 2026
Merged

Packaging#5
stella-bourdin merged 29 commits into
stella-bourdin:mainfrom
leosaffin:packaging

Conversation

@leosaffin

@leosaffin leosaffin commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Various updates for packaging

  1. Use pyproject.toml
  2. Add automated tests
  3. Add documentation with sphinx (we will need to add the extras for readthedocs still)
  4. Ruff format/check fixes (lower case)
  5. Update version number to 1.0.0

A few changes to the module itself

  1. Lower case function names
  2. Rearrange where/what is importable
  3. Vectorise VT computation
  4. Remove need for sorting by pressure levels
  5. Have pressure levels as an optional input to main function (and VT)
  6. Simplify area weighting
  7. Use huracanpy for angle calculation

I've also added a script for a speed test. All of these changes have been neutral or an improvement. Biggest improvement was vectorising the VT calculation (built in to the scipy function) rather than using a list comprehension. If there was a good reason for doing that, feel free to revert.

…eter. Allowing for modifying right_left function to work with vector and non-vector arguments
@leosaffin

Copy link
Copy Markdown
Collaborator Author

Turns out vectorized linregress is a fairly new thing. Needed to update python/scipy versions to match, but it is in line with which python versions xarray supports, so I think it's OK

@leosaffin
leosaffin requested a review from stella-bourdin May 18, 2026 08:34
@leosaffin

Copy link
Copy Markdown
Collaborator Author

Might be worth running the copilot thing in #4 again on this. I think I've fixed most, but not all, of the issues it raised

@stella-bourdin

Copy link
Copy Markdown
Owner

Might be worth running the copilot thing in #4 again on this. I think I've fixed most, but not all, of the issues it raised

Copilot doesn't want to work on cross-repo PRs, but I'll merge this one and then ask it to update the audit in #4

@stella-bourdin
stella-bourdin merged commit e97bc2a into stella-bourdin:main May 18, 2026
4 checks passed
@leosaffin
leosaffin deleted the packaging branch May 18, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants