Packaging#5
Merged
Merged
Conversation
…ataset and variable name
…eter. Allowing for modifying right_left function to work with vector and non-vector arguments
Collaborator
Author
|
Turns out vectorized linregress is a fairly new thing. Needed to update python/scipy versions to match, but it is in line with which python versions xarray supports, so I think it's OK |
Collaborator
Author
|
Might be worth running the copilot thing in #4 again on this. I think I've fixed most, but not all, of the issues it raised |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various updates for packaging
A few changes to the module itself
I've also added a script for a speed test. All of these changes have been neutral or an improvement. Biggest improvement was vectorising the VT calculation (built in to the scipy function) rather than using a list comprehension. If there was a good reason for doing that, feel free to revert.