Skip to content

fix(photo-annotator): repair selection model (deselect, tool-switch, group shapes)#1530

Merged
steilerDev merged 1 commit into
betafrom
fix/photo-annotator-selection
May 19, 2026
Merged

fix(photo-annotator): repair selection model (deselect, tool-switch, group shapes)#1530
steilerDev merged 1 commit into
betafrom
fix/photo-annotator-selection

Conversation

@steilerDev
Copy link
Copy Markdown
Owner

Summary

Three critical selection bugs fixed:

  • Bug 1: Background clicks now deselect (walk parent chain to find shape-* id)
  • Bug 2: Selection clears when switching tools (SET_TOOL reducer resets selectedShapeId)
  • Bug 3: Measurements and group shapes can now be selected (Group onClick + parent walk)

All tests pass (109 passed, 4 suites).

…group shapes)

- Fix Bug 1: Background clicks now properly deselect shapes by walking parent chain
- Fix Bug 2: Selection clears when switching tools (SET_TOOL reducer now resets selectedShapeId)
- Fix Bug 3: Measurement and group-based shapes can now be selected via parent walk + Group onClick

Fixes user feedback: deselection, tool-switching, and measurement selection all work correctly.

Co-Authored-By: Claude frontend-developer (claude-haiku-4-5) <noreply@anthropic.com>
@steilerDev steilerDev merged commit 1f615d0 into beta May 19, 2026
30 of 32 checks passed
@steilerDev steilerDev deleted the fix/photo-annotator-selection branch May 19, 2026 22:35
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.6.0-beta.65 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant