fix(photo-annotator): drop callout, unify line/arrow/measurement#1529
Merged
Conversation
…itives
Changes:
- Remove CalloutShape entirely from useUndoStack, useAnnotator type unions
- Remove 'callout' from ToolName type union
- Delete callout button and CalloutIcon from ToolPalette
- Delete callout rendering branch from renderKonvaShape
- Delete callout branches from PhotoAnnotator text input, commitment, and keyboard handlers
- Remove callout entries from all i18n files (en, de)
Line/Arrow/Measurement unification:
- Measurement now renders as Arrow with pointerAtBeginning + pointerAtEnding for tick marks
- Arrow fill fix: use fill={stroke} instead of fill="none" to show solid arrowheads at small widths
- Arrow draft preview: add pointerLength/pointerWidth proportional to strokeWidth
- Measurement draft preview: render as Arrow with dual tips like committed shape
- Measurement inline input positioning: fixed to open at midpoint (not startX/startY)
- Measurement inline input label offset: now uses perpendicular offset (+labelOffsetX/Y)
- Measurement committed label: perpendicular offset fixed to work on any axis (not just horizontal)
- Canvas renderer measurement: draw dual arrowheads at both ends instead of perpendicular ticks
Test updates required:
- ToolPalette.test.tsx: 5 tests reference 'callout', need deletion by QA
- PhotoAnnotator.test.tsx: several tests reference callout tool, need deletion by QA
Co-Authored-By: Claude frontend-developer (claude-haiku-4-5) <noreply@anthropic.com>
Callout tool was removed from production code in PR #1529. This removes all callout-specific tests from ToolPalette.test.tsx and PhotoAnnotator.test.tsx, and replaces 'callout' selectedTool usages in font-size tests with 'text'. Co-Authored-By: Claude <qa-integration-tester> (claude-haiku-4-5) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.6.0-beta.64 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
steilerDev
pushed a commit
that referenced
this pull request
May 19, 2026
PR #1529 dropped the Callout tool but the E2E test suite still asserted "all 10 tools visible" and referenced viewer.calloutToolButton. With fail-fast on the E2E shards, this single failure cancelled all 16 shards. - Update Scenario 1 (smoke) to assert 9 tool buttons. - Update Scenario 22 to assert 9 tool buttons and drop callout from the iteration list. - Delete the test.fixme placeholder for Scenario 12 (Callout tool). - Remove calloutToolButton, drawCallout helper, and the 'callout' member of AnnotatorToolName from the page object. Co-Authored-By: Claude <e2e-test-engineer> (claude-haiku-4-5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive refactor removing the problematic Callout tool and unifying line, arrow, and measurement as shared line-segment primitives with varying end-cap rendering.
Test Plan
npm run typecheckvalidates all type removals🤖 Generated with Claude Code