Add get_table_data_iter and get_table_data_all_iter#10
Merged
Conversation
The new methods are iterators that yield from the response chunks from .fetch without collecting the full into a list, thus saving memory for large responses. Changes get_table_data and get_table_data_all to be thin wrappers around their corresponding _iter methods that only collect the full result into a list.
Owner
|
Nice! I'll give it a test drive and then merge (CI failing unrelated). |
Owner
|
Works great, I just had to remember to also turn off the requests cache and the RAM usage was dramatically lower as expected. I should probably put that into the documentation. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new methods are iterators that yield from the response chunks
from .fetch without collecting the full response into a list, thus saving memory
for large responses.
Changes get_table_data and get_table_data_all to be thin wrappers around
their corresponding _iter methods that only collect the full result
into a list.
Should fix #9