fix: read LIB directly from responseWriter in UpdateBlockNumberMiddleware#262
Merged
Conversation
ety001
force-pushed
the
pr/08-fix-lib-middleware-read
branch
from
970cd61 to
401f82b
Compare
Both /health and / (homepage) endpoints now return last_irreversible_block_num instead of head_block_number, matching jussi legacy behavior. The value is sourced from BlockNumberTracker which is passively updated by UpdateBlockNumberMiddleware from get_dynamic_global_properties responses. Removed GlobalParams (global_params.go) which actively polled steemd for head_block_number - no longer needed and was returning the wrong field.
…ware
The middleware ordering caused response_body to not be set yet when
UpdateBlockNumberMiddleware tried to read it (c.Next() returns in LIFO
order, so ResponseCaptureMiddleware's post-Next code runs after
UpdateBlockNumberMiddleware's post-Next code).
Fix: read directly from the responseWriter wrapper instead of relying
on c.Get("response_body"), which is set too late in the middleware chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The middleware ordering caused response_body to not be set yet when UpdateBlockNumberMiddleware tried to read it (c.Next() returns in LIFO order, so ResponseCaptureMiddleware's post-Next code runs after UpdateBlockNumberMiddleware's post-Next code).
Fix: read directly from the responseWriter wrapper instead of relying on c.Get(response_body), which is set too late in the middleware chain.