Skip to content

Remove --max-turns limit from review panel workflow #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stbenjam merged 1 commit into from
Jul 26, 2026
Merged

Remove --max-turns limit from review panel workflow #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/skillsaw-review-panel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
show_full_output: true
claude_args: |
--allowedTools Edit,Write,Read,Bash,WebFetch,WebSearch,Skill,Glob,Grep,TaskCreate,TaskUpdate,TaskList,TaskGet
--max-turns 50
--model claude-opus-5

Comment on lines 41 to 45

@qodo-code-review qodo-code-review Bot Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Unbounded panel review runtime 🐞 Bug ☼ Reliability

Removing --max-turns from skillsaw-review-panel.yml leaves the Claude run without an explicit
iteration bound or job timeout, so a stalled/looping session can consume the full Actions runtime
and delay subsequent panel-review triggers for the same PR due to the workflow’s concurrency
grouping.
Agent Prompt 
## Issue description
The review panel workflow no longer passes a `--max-turns` guard, and the job also doesn’t set `timeout-minutes`. This makes the run length depend on external defaults and GitHub Actions hard limits, increasing the chance that a loop/stall consumes excessive runtime and delays later triggers.

## Issue Context
Other Skillsaw workflows in this repo still use an explicit turn cap (e.g., `--max-turns 200`), indicating a convention to keep agent runs bounded.

## Fix Focus Areas
- .github/workflows/skillsaw-review-panel.yml[7-9]
- .github/workflows/skillsaw-review-panel.yml[33-45]

### Suggested fix
- Add a job-level `timeout-minutes` (e.g. 60–120) to cap worst-case runtime.
- Optionally reintroduce a higher `--max-turns` value (e.g. 200) instead of removing it entirely, matching other workflows’ guardrails.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

- name: Upload execution log
Expand Down