Remove --max-turns limits from issue_solver and pr_followup - #456
Conversation
The max-turns caps (200 for issue_solver, 100 for pr_followup) truncate agent work on complex tasks, losing progress mid-solve. Removing these limits lets Claude run to completion. Evidence: https://github.com/stbenjam/skillsaw/actions/runs/30209909213/job/89814287177 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughRemoves conditional ChangesClaude workflow argument updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoRemove max-turns caps from Issue Solver and PR Follow-up workflows
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
136 rules✅ Skills:
|
| claude_args: | | ||
| --dangerously-skip-permissions | ||
| ${{ !matrix.issue.ultracode && '--max-turns 200' || '' }} | ||
| --model ${{ matrix.issue.fable && 'claude-fable-5' || 'claude-opus-5' }} | ||
| ${{ matrix.issue.ultracode && '--effort ultracode' || '' }} |
There was a problem hiding this comment.
2. Removed max-turns cap 🐞 Bug ☼ Reliability
The Issue Solver and PR Follow-up workflows no longer pass explicit non-ultracode --max-turns caps (previously 200 and 100 respectively), removing a turn-budget guardrail and allowing substantially longer Claude runs than before. Because both are scheduled and share concurrency: skillsaw-agent with cancel-in-progress: false, unusually long runs can serialize the queue and delay other agent workflows from starting.
Agent Prompt
## Issue description
The Issue Solver and PR Follow-up workflows removed the explicit `--max-turns` guardrail for non-ultracode runs, so the Claude steps can take much longer than they used to and potentially run unbounded.
## Issue Context
Both workflows are scheduled every 15 minutes and share a single concurrency group (`skillsaw-agent`) with `cancel-in-progress: false`, which means long-running executions serialize the pipeline and can delay subsequent scheduled agent work (including later Issue Solver runs and PR follow-ups).
## Fix Focus Areas
- .github/workflows/skillsaw-issue-solver.yml[3-11]
- .github/workflows/skillsaw-issue-solver.yml[100-138]
- .github/workflows/skillsaw-pr-followup.yml[3-11]
- .github/workflows/skillsaw-pr-followup.yml[128-170]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 145 145
Lines 11418 11418
=======================================
Hits 10681 10681
Misses 737 737 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The review panel was hitting the 50-turn cap and failing. This follows the same change made in #456 for the issue_solver and pr_followup workflows. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
--max-turns 200from the issue_solver workflow--max-turns 100from the pr_followup workflowThese caps truncate agent work on complex tasks, losing progress mid-solve. Without them, Claude runs to completion naturally.
Evidence
Failed run where work was truncated by the turns limit:
https://github.com/stbenjam/skillsaw/actions/runs/30209909213/job/89814287177
Test plan
--max-turnslines removed🤖 Generated with Claude Code
Summary by CodeRabbit