Skip to content

deployment: sequencer selector labels#14292

Open
idan-starkware wants to merge 1 commit into
main-v0.14.3from
idan/main-v0.14.3/fix-sequencer-selector-label-bug
Open

deployment: sequencer selector labels#14292
idan-starkware wants to merge 1 commit into
main-v0.14.3from
idan/main-v0.14.3/fix-sequencer-selector-label-bug

Conversation

@idan-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@idan-starkware idan-starkware self-assigned this Jun 1, 2026
@cursor

cursor Bot commented Jun 1, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Incorrect pod selectors can prevent rollouts or leave Services pointing at no endpoints; the change is small but directly affects which pods workloads manage.

Overview
Deployment and StatefulSet matchLabels now use app: sequencer and service: sequencer-<service name> instead of selecting pods with only the service value taken from the merged label map.

This makes workload selectors explicit and consistent per sequencer component (e.g. core vs committer) rather than relying on whatever service ended up on statefulset_labels.

Reviewed by Cursor Bugbot for commit 849684b. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware).

@idan-starkware idan-starkware force-pushed the idan/main-v0.14.3/fix-sequencer-selector-label-bug branch from 11146b0 to 849684b Compare June 2, 2026 06:39
@idan-starkware idan-starkware changed the title fix: sequencer selector labels deployment: fix sequencer selector labels Jun 2, 2026
@ShahakShama ShahakShama changed the title deployment: fix sequencer selector labels deployment: sequencer selector labels fix Jun 4, 2026
@ShahakShama ShahakShama changed the title deployment: sequencer selector labels fix deployment: sequencer selector labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants