starknet_transaction_prover: proving-job duration + outcome metrics#14168
starknet_transaction_prover: proving-job duration + outcome metrics#14168avi-starkware wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 931d783. Bugbot is set up for automated code reviews on this repo. Configure here. |
7d179cb to
a0e7299
Compare
5eb413f to
186e4cf
Compare
a0e7299 to
00671e6
Compare
186e4cf to
9959caa
Compare
00671e6 to
68683f0
Compare
9959caa to
1733122
Compare
00f7551 to
b51be4a
Compare
1733122 to
4403df0
Compare
b51be4a to
396774b
Compare
3e19b68 to
f196a34
Compare
fb01d37 to
f1b98e4
Compare
7c12cba to
aa40e3d
Compare
9898133 to
6974938
Compare
aa40e3d to
3790635
Compare
6974938 to
d0b3654
Compare
6834e33 to
c055b5f
Compare
d0b3654 to
d84bd92
Compare
c055b5f to
b9b156a
Compare
b2da23d to
ac34a57
Compare
b9b156a to
69e6de4
Compare
ac34a57 to
97f32a2
Compare
8abd666 to
bca1e04
Compare
97f32a2 to
15f1abf
Compare
Adds Prometheus counters / histograms recorded by `VirtualSnosProver` for each proving job: total count by outcome (`success`, `validation_error`, `internal_error`, `l1_provider_error`) and end-to-end duration. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bca1e04 to
bc665d6
Compare
15f1abf to
931d783
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 931d783. Configure here.
| let prove_duration = prove_start.elapsed(); | ||
| metrics::histogram!(metric_names::STWO_PROVE_DURATION_SECONDS) | ||
| .record(prove_duration.as_secs_f64()); | ||
| info!(prove_duration_ms = %prove_duration.as_millis(), "Proving completed"); |
There was a problem hiding this comment.
Sub-step histograms skip failures
Medium Severity
In run_and_prove, OS_RUN_DURATION_SECONDS and STWO_PROVE_DURATION_SECONDS are recorded only after run_virtual_os and prove_virtual_snos_run succeed. When either step returns an error via ?, the elapsed time for that step is never observed, so failure-path latency is missing from sub-step histograms while the end-to-end histogram still includes it.
Reviewed by Cursor Bugbot for commit 931d783. Configure here.



Adds Prometheus counters / histograms recorded by
VirtualSnosProverforeach proving job: total count by outcome (
success,validation_error,internal_error,l1_provider_error) and end-to-end duration.Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com