Bump stwo-circuits to 33a14cd6.#361
Conversation
Update stwo-circuits from 618db0a to 33a14cd6 (stwo-cairo stays at 0a5e70b7, matching what stwo-circuits@33a14cd6 depends on). API migrations: - ProofConfig::new no longer takes an enabled_bits argument. - CairoVerifierConfig gained a required enabled_bits field, derived from all_components() order via a new get_cairo_enabled_bits() helper. - CircuitConfig.output_addresses replaced by n_outputs; the u anchor wire (address 2) is now appended internally by the verifier, so it is excluded from both n_outputs and the recursive output_values. - prepare_cairo_proof_for_circuit_verifier now takes the component enable bits. Regenerated PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOT for the new circuit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PR SummaryHigh Risk Overview Adapts to upstream API changes: Reviewed by Cursor Bugbot for commit 299d84a. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 59.19% 59.26% +0.06%
==========================================
Files 35 35
Lines 5303 5312 +9
==========================================
+ Hits 3139 3148 +9
Misses 2164 2164
🚀 New features to boost your workflow:
|
gilbens-starkware
left a comment
There was a problem hiding this comment.
@gilbens-starkware reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on anatgstarkware).
Summary
stwo-circuitsfrom618db0a→33a14cd6(current main) across bothprivacy_proveandprivacy_circuit_verify.stwo-cairostays at0a5e70b7— that's the revstwo-circuits@33a14cd6itself depends on.API migrations
ProofConfig::newno longer takes anenabled_bitsargument.CairoVerifierConfiggained a requiredenabled_bitsfield, derived fromall_components()order via a newget_cairo_enabled_bits()helper.CircuitConfig.output_addressesreplaced byn_outputs; theuanchor wire (address 2) is now appended internally by the verifier, so it is excluded from bothn_outputsand the recursiveoutput_values.prepare_cairo_proof_for_circuit_verifiernow takes the component enable bits as a third argument.PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOTfor the new circuit.Testing
Run with
--releaseandRUST_MIN_STACK=4194304(matching CI):privacy-circuit-verify(incl.slow-tests): 8 passed ✓privacy-proveslow end-to-end (test_privacy_prove_and_verify,test_privacy_recursive_prove_and_verify): 2 passed ✓🤖 Generated with Claude Code
This change is