chore(skills): Intent naming — persist / persist-* / <fw>-persist#39
Conversation
Composition naming avoids clashing with upstream library skill leaves; ship persist-zustand as the next source tracer and record the rest in skills/_artifacts/skill_tree.yaml.
🦋 Changeset detectedLatest commit: a137334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (31)
📝 WalkthroughWalkthroughChangesIntent skill expansion
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/check-skills.yml (1)
40-40: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winInvoke the locked Intent dependency in CI.
Both jobs install the exact direct version globally, but its transitive dependency tree is resolved outside the repository’s lockfile. Prefer invoking the repository-pinned CLI through a lockfile-based install, using the same approach in both jobs.
Also applies to: 64-64
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/check-skills.yml at line 40, Update both jobs in the workflow to install dependencies through the repository’s lockfile and invoke the pinned `@tanstack/intent` CLI from that installation instead of globally installing the direct version. Use the same lockfile-based approach for both command steps, preserving the configured Intent version from the repository dependency declarations.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/check-skills.yml:
- Line 40: Update both jobs in the workflow to install dependencies through the
repository’s lockfile and invoke the pinned `@tanstack/intent` CLI from that
installation instead of globally installing the direct version. Use the same
lockfile-based approach for both command steps, preserving the configured Intent
version from the repository dependency declarations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 659558e0-d3b9-46c6-aaaf-4cab13e54d41
📒 Files selected for processing (7)
.changeset/intent-skills-rename.md.github/workflows/check-skills.ymlpackage.jsonscripts/sync-skill-versions.tsskills/_artifacts/skill_tree.yamlskills/persist-tanstack-store/SKILL.mdskills/persist-zustand/SKILL.md
Add persist-core (required by framework skills), jotai/valtio/mobx/pinia/redux composition leaves, and persist-react useHydrated. Remaining frameworks stay planned in skills/_artifacts/skill_tree.yaml.
SutuSebastian
changed the title
Cover preact, vue, solid, angular, lit, alpine, svelte runes, and svelte-store so agent guidance matches the full public hydration surface.
SutuSebastian
changed the title
Sources stay persist-*; framework leaves flip to Intent-style react-persist / vue-persist / …; persist-core becomes persist.
SutuSebastian
changed the title
Cover seroval, standard-schema, idb, async-storage, mmkv, secure-store, encrypted, compressed, node-fs, and BroadcastChannel crosstab as persist-* composition leaves so agent guidance matches every opt-in subpath.
Correct migrate/one-shot, alpine $hydrated bag, IDB encrypt compose, pinia/$state+merge, jotai readonly typing; slim tanstack-store sprawl and drop no-op persist pointers (requires already loads core).
Avoid npm install -g so @tanstack/intent and its transitive tree resolve from bun.lock like the rest of CI.
PR comment fact-check (unresolved threads: 0)Only actionable claim was CodeRabbit’s review-body nit on Verdict: ✅ Correct — pinned major is fine, but transitive deps still resolve outside CodeRabbit walkthrough still mentions Changeset-bot: informational only. |
Copy-paste wiring now matches Install (JSON default storage; crosstab/ secure-store declare example peers; CryptoKey shown for encrypted).
1 participant
Summary
persistpersist-<name><framework>-persist./sources/*,./codecs/*,./backends/*,./transport/*, and./frameworks/*entryTest plan
bun run intent:validatenpm pack --dry-runships SKILL.md; excludes_artifactscheck-skillsgreen