feat: add support for testnet4#7216
Open
brice-stacks wants to merge 5 commits into
Open
Conversation
50f73eb to
5ffb44e
Compare
Coverage Report for CI Build 26182114351Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.1%) to 85.573%Details
Uncovered Changes
Coverage Regressions5672 previously-covered lines in 110 files lost coverage.
Coverage Stats
💛 - Coveralls |
| (_, BitcoinNetworkType::Mainnet) => PoxConstants::mainnet_default(), | ||
| (_, BitcoinNetworkType::Testnet) => PoxConstants::testnet_default(), | ||
| (_, BitcoinNetworkType::Testnet) | (_, BitcoinNetworkType::Testnet4) => { | ||
| PoxConstants::testnet_default() |
Contributor
There was a problem hiding this comment.
Side note: The Testnet config here is completely broken, as I discovered the other day. This should be nakamoto_testnet_default(), and a couple of other things (pox constants, first block, ...) also need to be changed.
There's also references in the code to an "old hiro testnet" that no longer exists.
Not sure that that matters for anything here, just felt like a good time to mention it.
aaronb-stacks
previously approved these changes
May 20, 2026
Contributor
Author
|
Putting this on hold until we decide if we really need to support testnet4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo