Skip to content

Fix CI checks polling feedback#5254

Open
AmethystLiang wants to merge 1 commit into
mainfrom
fix-ci-polling-feedback-5252
Open

Fix CI checks polling feedback#5254
AmethystLiang wants to merge 1 commit into
mainfrom
fix-ci-polling-feedback-5252

Conversation

@AmethystLiang

Copy link
Copy Markdown
Contributor

Summary\n- Make checks polling signatures order-insensitive so provider ordering flaps do not reset backoff\n- Preserve checks polling backoff during comment-only entry refreshes\n- Add focused coverage for reordered check arrays\n\n## Validation\n- pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/right-sidebar/checks-panel-polling.test.ts\n- pnpm run typecheck:web\n- git diff --check --cached

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1445f873-3f4c-46e7-952f-3e6a1e54f6a8

📥 Commits

Reviewing files that changed from the base of the PR and between 9c8d9be and 3891b29.

📒 Files selected for processing (3)
  • src/renderer/src/components/right-sidebar/ChecksPanel.tsx
  • src/renderer/src/components/right-sidebar/checks-panel-polling.test.ts
  • src/renderer/src/components/right-sidebar/checks-panel-polling.ts

📝 Walkthrough

Walkthrough

This PR fixes the checks polling backoff mechanism in two parts. First, it makes the checks signature computation stable against array reordering by mapping each check to a structured key of name, status, and conclusion, then sorting these keys before stringification. Second, it guards the polling state reset in ChecksPanel to occur only when the entry refresh will actually fetch checks, preventing comment-only refreshes from resetting the backoff baseline. A new test verifies the backoff remains consistent even when check ordering changes.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the three main objectives (order-insensitive signatures, backoff preservation, and test coverage) and includes validation steps, but is missing required sections like Screenshots, Testing checklist, AI Review Report, and Security Audit from the template. Add the missing template sections: Screenshots (with 'No visual change' if applicable), complete Testing checklist items, AI Review Report with cross-platform compatibility verification, and Security Audit summary.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix CI checks polling feedback' directly relates to the main changes: fixing checks polling behavior by making signatures order-insensitive and preserving backoff during comment-only refreshes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant