Fix CI checks polling feedback#5254
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR fixes the checks polling backoff mechanism in two parts. First, it makes the checks signature computation stable against array reordering by mapping each check to a structured key of name, status, and conclusion, then sorting these keys before stringification. Second, it guards the polling state reset in ChecksPanel to occur only when the entry refresh will actually fetch checks, preventing comment-only refreshes from resetting the backoff baseline. A new test verifies the backoff remains consistent even when check ordering changes. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary\n- Make checks polling signatures order-insensitive so provider ordering flaps do not reset backoff\n- Preserve checks polling backoff during comment-only entry refreshes\n- Add focused coverage for reordered check arrays\n\n## Validation\n- pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/right-sidebar/checks-panel-polling.test.ts\n- pnpm run typecheck:web\n- git diff --check --cached