Skip to content

Constrain right sidebar primary action widths#5248

Merged
AmethystLiang merged 1 commit into
mainfrom
max-width-to-right-side-buttons
Jun 12, 2026
Merged

Constrain right sidebar primary action widths#5248
AmethystLiang merged 1 commit into
mainfrom
max-width-to-right-side-buttons

Conversation

@AmethystLiang

@AmethystLiang AmethystLiang commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds shared right-sidebar primary action layout classes to keep morphing git/review buttons content-width with stable minimums and truncation for long labels.
  • Applies the constrained layout across Source Control, hosted review creation/actions, PR action panels, conflict actions, and operation banners.
  • Updates the review ship visual mock so its split action button reflects the same fixed-width behavior.

Testing

  • Not run; no test evidence provided.

Made with Orca 🐋

Introduce min-width constraints, truncation, and content-width layouts
for primary actions in the right sidebar and PR dialogs. This prevents
buttons from shifting layout dramatically when labels morph dynamically
as git and review state changes.
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ccc0689b-0bb0-463b-8c02-8b17f1233d45

📥 Commits

Reviewing files that changed from the base of the PR and between 2899a60 and 6e21c73.

📒 Files selected for processing (8)
  • src/renderer/src/components/GitHubItemDialog.tsx
  • src/renderer/src/components/PullRequestPage.tsx
  • src/renderer/src/components/feature-wall/review-animated-visual-ship-styles.tsx
  • src/renderer/src/components/right-sidebar/CreateHostedReviewComposer.tsx
  • src/renderer/src/components/right-sidebar/HostedReviewActions.tsx
  • src/renderer/src/components/right-sidebar/HostedReviewStateActions.tsx
  • src/renderer/src/components/right-sidebar/SourceControl.tsx
  • src/renderer/src/components/right-sidebar/right-sidebar-primary-action-layout.ts

📝 Walkthrough

Walkthrough

This PR consolidates scattered right-sidebar button styling classes into a single shared constants module, then refactors six components to import and apply these constants. The changes introduce right-sidebar-primary-action-layout.ts with six Tailwind class constants for primary action rows, buttons, and labels. Consuming components in PR pages (GitHubItemDialog, PullRequestPage), review composition (CreateHostedReviewComposer, HostedReviewActions, HostedReviewStateActions), and source control (SourceControl) are updated to use these constants. Layout adjustments also shift several buttons from full-width flex to inline-flex with constrained widths for more controlled sizing.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing critical required sections: Screenshots, Testing checkbox confirmation, AI Review Report with cross-platform verification, and Security Audit analysis. Add Screenshots section, complete Testing checklist with results, provide AI Review Report with cross-platform compatibility details, and include Security Audit findings.
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: constraining right sidebar primary action widths with shared layout classes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AmethystLiang AmethystLiang merged commit d27985e into main Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant