fix: CI timing overwrites and metrics plot generation#161
Merged
Conversation
Two issues from the QUIET mode CI run (#121): 1. **Timing overwrites:** The `test: stage2` dependency triggers the PHONY stage2 recipe again. Since everything is already built, the re-run completes in seconds, overwriting the real stage2 timings (16m 31s) with near-zero durations (3m 36s). Fix: guard PHASE_START/PHASE_END macros to skip writing if the phase already completed successfully (status=0). Failed phases can still be retried. 2. **Metrics plots:** The "Generate Metrics plots" CI step used `nix-shell -p ...` which is not available in the devx environment. Fix: replace `nix-shell` with `nix build --print-out-paths` to get the store path, then invoke the binary directly. Applied to both the matplotlib plot generation and the awscli R2 upload steps.
angerman
force-pushed
the
fix/ci-metrics-and-timings
branch
from
b6005a3 to
318a199
Compare
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues observed in the CI run for the QUIET mode PR (#121, run 22520789467):
Timing overwrites:
test: stage2re-triggers the PHONY stage2 recipe, overwriting real build timings (16m 31s → 3m 36s) with near-zero no-op durations. Fixed by guardingPHASE_START/PHASE_ENDmacros to skip writing once a phase completes successfully. Failed phases can still be retried.Metrics plot generation:
nix-shellis not available in the devx shell environment. Replaced withnix build --print-out-pathsto get the nix store path, then invoke binaries directly. Applied to both matplotlib (plot generation) and awscli (R2 upload).Test plan
make testre-enters the stage2 target