feat: added file1 with errors#1
Open
ssilare-adobe wants to merge 3 commits into
Open
Conversation
WalkthroughThis update introduces a new function named Changes
|
There was a problem hiding this comment.
Files selected (1)
- file1.js (1)
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with
AEM PR Review Bot (@aem-pr-review-bot)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@aem-pr-review-botin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@aem-pr-review-bot: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
+1
to
+3
| function 21() { | ||
| console.log(str); | ||
| } |
There was a problem hiding this comment.
The function name 21 is not valid in JavaScript. Function names must start with a letter, underscore (_), or dollar sign ($). Additionally, the variable str is used without being declared, which will cause a reference error.
- function 21() {
+ function logString(str) {
console.log(str);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by AEM PR Review Bot