fix: filter stale cache entries in capture_initial_cached_targets and clean orphans on every build#9
Merged
Conversation
… clean orphans on every build #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Problem
should_rerender_for_sidebarcomparesbuild_targetsagainst a snapshot of_cached/directories. When stale cache entries from deleted sources remain in_cached/, every HTML target re-renders on every build.Changes
src/sdb/build.pycapture_initial_cached_targets: intersect withTARGET_CONFIG.keys()so stale entries are excluded from the comparison set.build_targets: call_cleanup_orphaned_caches(set(TARGET_CONFIG.keys()), docs_root)immediately aftercapture_initial_cached_targets, ensuring stale cache directories are physically removed every build cycle regardless of execution mode.tests/test_cache_lifecycle.py(new, 14 tests)capture_initial_cached_targetscorrectly filters stale entriesshould_rerender_for_sidebarcorrectly detects added/removed targets_cleanup_orphaned_cachescorrectly removes orphaned directories