PR: fix: reorder pre-build/post-render sequence and consolidate into shared functions #4#5
Merged
Merged
Conversation
metasmile
force-pushed
the
79-pre-build-order
branch
from
b63bf29 to
054ba2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reorder execution sequence: User-configured
pre_build/post_rendercommands (frombuild.yml) now run before built-in defaults (generate_latest_docs,resolve_all,rumdl fmt,generate_llms_txt). Previously defaults ran first, sosv2dot.py(build.yml user config) ran afterrumdl fmt, leaving SVG files unknown to the formatter.Consolidate shared logic: Extracted
run_pre_build_sequence()andrun_post_render_sequence()so bothsdb buildandsdb preuse identical code paths.Fix
sdb preorder:sdb prewas still running built-in defaults before user config; now matchessdb buildbehavior.Closes #4