Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ent-OreBag = сумка для материалов
.desc = Прочная сумка для специалистов по утилизации и шахтёров для переноски больших объёмов материалов. Примагничивает близлежащие материалы, если закрепить на поясе.
9 changes: 9 additions & 0 deletions Resources/Prototypes/_Art/Catalog/Cargo/cargo_cargo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
- type: cargoProduct
id: CargoCrateMaterialsBags
icon:
sprite: /Textures/Structures/Storage/orebox.rsi
state: icon
product: CrateCargoMaterialsBags
cost: 1200
category: cargoproduct-category-name-cargo
group: market
13 changes: 13 additions & 0 deletions Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
- type: entity
parent: CratePirate
id: CrateCargoMaterialsBags
name: luxury material bag crate
description: Contains 3 bags for materials.
components:
- type: EntityTableContainerFill
containers:
entity_storage: !type:AllSelector
children:
- id: MaterialBag
- id: MaterialBag
- id: MaterialBag
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
- type: entity
name: material bag
id: MaterialBag

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Use fork-named IDs for all new prototypes.

These IDs are new fork content but use unprefixed names. Rename each ID with the repository’s fork naming convention and update all cross-file references.

  • Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml#L3: rename MaterialBag; update the three crate contents.
  • Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml#L3: rename CrateCargoMaterialsBags; update the cargo product reference.
  • Resources/Prototypes/_Art/Catalog/Cargo/cargo_cargo.yml#L2: rename CargoCrateMaterialsBags and update any catalog references.

As per path instructions: Resources/Prototypes/_Art/**/*.yml requires fork content IDs to be fork-named to avoid collisions with upstream IDs.

📍 Affects 3 files
  • Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml#L3-L3 (this comment)
  • Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml#L3-L3
  • Resources/Prototypes/_Art/Catalog/Cargo/cargo_cargo.yml#L2-L2
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml` at
line 3, Rename the new prototype IDs using the repository’s fork naming
convention and update every reference: in
Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml:3
rename MaterialBag and update the three crate contents; in
Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml:3 rename
CrateCargoMaterialsBags and update its cargo product reference; in
Resources/Prototypes/_Art/Catalog/Cargo/cargo_cargo.yml:2 rename
CargoCrateMaterialsBags and update any catalog references.

Source: Path instructions

parent: OreBag
description: A robust bag for salvage specialists and miners alike to carry large amounts of material. Magnetises any nearby materials when attached to a belt.
Comment on lines +2 to +5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Use one fork-owned localization contract for the new player-facing prototypes.

The new prototypes use raw English fields, while the added FTL entry targets ent-OreBag. Use matching fork-prefixed, kebab-case keys, define the base keys under Resources/Locale/en-US/_Art/, and add locale-specific translations with the same keys.

  • Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml#L2-L5: replace the raw MaterialBag name and description.
  • Resources/Locale/ru-RU/_Art/prototypes/entities/objects/specific/bags/ore_bag.ftl#L1-L2: replace ent-OreBag with the fork key for MaterialBag.
  • Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml#L4-L5: replace the raw crate name and description.

As per coding guidelines: player-facing strings must use fork--prefixed keys in Resources/Locale/en-US/_Art/*.ftl. As per path instructions: prototype names and descriptions must use locale keys, and FTL keys must be fork-prefixed and kebab-case.

📍 Affects 3 files
  • Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml#L2-L5 (this comment)
  • Resources/Locale/ru-RU/_Art/prototypes/entities/objects/specific/bags/ore_bag.ftl#L1-L2
  • Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml#L4-L5
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml`
around lines 2 - 5, Replace the raw player-facing fields in
Resources/Prototypes/_Art/Entities/Object/Specific/bags/material_bag.yml:2-5 and
Resources/Prototypes/_Art/Catalog/Fills/Crates/cargo.yml:4-5 with matching
fork-prefixed, kebab-case locale keys. Define the corresponding base name and
description keys under Resources/Locale/en-US/_Art/, and update
Resources/Locale/ru-RU/_Art/prototypes/entities/objects/specific/bags/ore_bag.ftl:1-2
to use the fork key for MaterialBag with matching localized keys.

Sources: Coding guidelines, Path instructions

components:
- type: Storage
maxItemSize: Normal
grid:
- 0,0,9,3
quickInsert: true
areaInsert: true
whitelist:
tags:
- ConstructionMaterial
Loading