-
Notifications
You must be signed in to change notification settings - Fork 8
addMaterialBox #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
addMaterialBox #41
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ent-OreBox = ящик для материалов | ||
| .desc = Большой контейнер для хранения строительных материалов. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| - type: cargoProduct | ||
| id: CargoMaterialBox | ||
| icon: | ||
| sprite: /Textures/Structures/Storage/orebox.rsi | ||
| state: orebox | ||
| cost: 300 | ||
| category: cargoproduct-category-name-cargo | ||
| group: market | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| - type: entity | ||
| id: MaterialBox | ||
| name: material box | ||
| description: A large storage container for holding construction material. | ||
|
Comment on lines
+2
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Align the fork prototype identity across YAML and FTL. The prototype uses a generic ID and raw text, while the translation targets
As per coding guidelines: fork prototype IDs must be fork-named. As per path instructions: prototype display fields must use locale keys, and fork locale keys must be 📍 Affects 2 files
🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
| parent: OreBox | ||
| components: | ||
| - type: Storage | ||
| grid: | ||
| - 0,0,19,9 | ||
| maxItemSize: Normal | ||
| storageOpenSound: /Audio/Effects/closetopen.ogg | ||
| storageCloseSound: /Audio/Effects/closetclose.ogg | ||
| whitelist: | ||
| tags: | ||
| - ConstructionMaterial | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| - type: constructionGraph | ||
| id: MaterialBoxGraph | ||
| start: start | ||
| graph: | ||
| - node: start | ||
| edges: | ||
| - to: material_box | ||
| steps: | ||
| - material: Steel | ||
| amount: 7 | ||
| doAfter: 1 | ||
|
|
||
| - node: material_box | ||
| entity: MaterialBox |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| - type: construction | ||
| id: MaterialBox | ||
| graph: MaterialBoxGraph | ||
|
Comment on lines
+2
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Use fork-named IDs for all The construction, graph, and entity identifiers use generic names. Rename the fork-owned prototypes with the repository’s established fork prefix, then update all references.
As per coding guidelines, prototype IDs for fork content must be fork-named to avoid collisions with upstream IDs. 📍 Affects 2 files
🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| startNode: start | ||
| targetNode: material_box | ||
| category: construction-category-storage | ||
| objectType: Structure | ||
| placementMode: SnapgridCenter | ||
| canBuildInImpassable: false | ||
| conditions: | ||
| - !type:TileNotBlocked | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Link the cargo product to
MaterialBox.The cargo product does not define a
productfield. Cargo listings use this field to identify the entity to spawn, as shown byCargoOreBox. Addproduct: MaterialBox; otherwise, purchasingCargoMaterialBoxmay not provide the new storage box.Proposed fix
- type: cargoProduct id: CargoMaterialBox icon: sprite: /Textures/Structures/Storage/orebox.rsi state: orebox + product: MaterialBox cost: 300 category: cargoproduct-category-name-cargo group: market📝 Committable suggestion
🤖 Prompt for AI Agents